Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Separate MetadataSync and UserMetadataSync #655

Closed
sssoleileraaa opened this issue Dec 10, 2019 · 5 comments
Closed

[refactor] Separate MetadataSync and UserMetadataSync #655

sssoleileraaa opened this issue Dec 10, 2019 · 5 comments

Comments

@sssoleileraaa
Copy link
Contributor

Description

We handle errors for metadata syncs differently depending on whether or not it was user-initiated. In the future we may also change the priority of a user-initiated metadata sync vs background metadata sync, so it makes sense to create a separate job for this. Name ideas (because I love naming things): UserMetadataSync or RefreshMetadataSync

@eloquence
Copy link
Member

This refactoring is necessary as part of the work get us to greater responsiveness for user-initiated actions and higher frequency of syncs (see #652 and #657), so added to beta milestone.

@eloquence
Copy link
Member

Stepping back: Given the planned higher frequency of background syncs, do we want to keep user-initiated metadata syncs around at all? There was a justification for having them if the user had to wait several minutes otherwise -- but if we're basically syncing as fast as we can, constantly, there may be little value in maintaining this additional logic, and indeed, it may cause the user to waste emotional energy worrying about something the application takes care of.

@sssoleileraaa
Copy link
Contributor Author

Good question. I agree with removing this refresh feature once we increase the frequency of background syncs. Unless we want to allow an admin to configure the sync frequency so that it could potentially be >30 seconds between syncs, I think we don't need this feature.

@eloquence
Copy link
Member

Unless we want to allow an admin to configure the sync frequency so that it could potentially be >30 seconds between syncs

Are you thinking about that from a perspective for maintaining longer "radio silence" for security reasons? If so, I think offline mode is the better option here -- and post-beta, putting more time into making offline mode more useful seems a better investment of time to me.

@ninavizz and I discussed this a bit today, and she'll do a small exploration about the UX implications of not having user-initiated sync (e.g., does it even make sense to have a refresh icon, if we go down this route). I'll add a bit more background on #343 as well.

@redshiftzero
Copy link
Contributor

Let's proceed with moving the MetadataSyncJob to a more frequent time interval (tracked in #652) and then we won't need to have User initiated syncs, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants