Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending a reply results in autoscrolling to top of conversation pane #635

Closed
sssoleileraaa opened this issue Dec 3, 2019 · 1 comment · Fixed by #688
Closed

Sending a reply results in autoscrolling to top of conversation pane #635

sssoleileraaa opened this issue Dec 3, 2019 · 1 comment · Fixed by #688
Labels
bug Something isn't working

Comments

@sssoleileraaa
Copy link
Contributor

STR

  1. Send enough replies so that you can see the scrollbar appear in the conversation pane and see how you are autoscrolled to the top of this window.

This code may need to be re-examined:

# Completely unintuitive way to ensure the view remains scrolled to the bottom.
sb = self.scroll.verticalScrollBar()
sb.rangeChanged.connect(self.update_conversation_position)

@eloquence eloquence added the bug Something isn't working label Dec 3, 2019
@deeplow
Copy link
Contributor

deeplow commented Dec 7, 2019

I definitely remember doing this part. The change was introduced in one of my PRs (#249). At the time it seemed to work, but the code was indeed a bit fragile and needs re-examining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants