Need a pending source deletion state

[sssoleileraaa]

Description

When you tell the client to delete a source from the source list in qubes, it takes a while before it actually happens, so it would be helpful the uesr to show an activity message or some kind of pending state.

Once we have a pending state, we can readd a failed deletion job back to the queue on timeout so it will be retried after the connection issue is fixed. This is because it'll be more apparent to the user that the deletion is pending. For other errors we will display the error message "Failed to delete source at server" which could use a rewrite to be more user-friendly.

[eloquence]

@ninavizz has done some UX exploration on this, I believe the solution we settled on was to try for a placeholder screen in the conversation area similar to the "Nothing to see here" one we show on first-run of the client, which would be shown for a source whose deletion is pending when you select it.

[ninavizz]

Deletion Flow

Note: Some of the below states and screens reflect post-Beta additions.

• Zeplin Screens
• Delete button hover
  • The delete button as shown, I don't believe is in the current client, nor is it scoped-in as a priority for Beta. As such, ignore if tpr
• In Progress deletion
  • Selected source
  • Not-selected source
  • Note: Use same spinner created for Download, but size according to this Zeplin thingy

[eloquence]

Thanks, @ninavizz. That's a great starting point to arrive at a scope sufficient to address this issue for beta.

I believe this screen is very close to what we ultimately want. I do worry about the complexity of the alpha overlay. We'd have to ensure that no interaction with any of the clickable elements for a source in this mode is possible, and we'd probably want to disable all hover/active states as well.

I would love an assessment from one of the implementers on the complexity of the alpha overlay portion:

Regarding the source list portion:

I'm not sure that removing the source name for a source whose deletion is in progress is a good idea. That makes it impossible for the journalist to know exactly what's being deleted if they switch away from the source. I would prefer to keep the designation visible in the list.

I think the simplest possible iteration would be:

• Use the preview snippet area to hold a "Deletion in progress" text
• If the user selects the source, show content similar to the conversation area content of the empty state screen. The text could say something to this effect: "Deletion in progress. This source will be removed once it has been deleted on the server".

[eloquence]

@creviera @redshiftzero Any thoughts on the implementation complexity of the translucent overlay "pending state" design for the conversation area, highlighted in the comment immediately above? My fear is that ensuring that all states are correctly disabled (including hover states for buttons, reply box "send" button, etc.) while a source is in "pending delete" mode could turn out to be pretty complex.

Do you think it would make sense do a time-boxed investigation of that translucent overlay, or would you prefer for @ninavizz to design a simpler iteration more like the text placeholder we put in the conversation area when there are no sources yet?

[sssoleileraaa]

• Use the preview snippet area to hold a "Deletion in progress" text

👍

• If the user selects the source, show content similar to the conversation area content of the empty state screen. The text could say something to this effect: "Deletion in progress. This source will be removed once it has been deleted on the server".

👍

Do you think it would make sense do a time-boxed investigation of that translucent overlay, or would you prefer for @ninavizz to design a simpler iteration more like the text placeholder we put in the conversation area when there are no sources yet?

I think this should be investigated post-beta

[eloquence]

@ninavizz will take a stab at a more minimalist design and we can decide if we can still realistically implement a version of this, which may be important for deletion to behave in a consistent way that's not confusing.

[ninavizz]

Per today's UX meeting, below is the solution for Beta that was discussed.
Zeplin, here.

Mockup reflects updated styling to the No Source Selected screen, as a generalized template for empty screens. Since the No Source Selected screen is shown just after this one when the deleted source is still selected, it'd be extra awesome if that transition could be as elegant as the Invision here suggests*... but, as always, totally understood if that's not in the cards given all the other priorities. :)

NOTE: Invision has no hotspots, click on a screen and navigate w/ cursor keys.

[sssoleileraaa]

closed by #911