Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout and display login dialog if token is invalid/expired #517

Closed
sssoleileraaa opened this issue Aug 5, 2019 · 3 comments
Closed

Logout and display login dialog if token is invalid/expired #517

sssoleileraaa opened this issue Aug 5, 2019 · 3 comments

Comments

@sssoleileraaa
Copy link
Contributor

Description

The queue should pause if it ever hits an auth error because it means the user token expired or is invalidated.

This will require the user to log out and log back in again.

@sssoleileraaa
Copy link
Contributor Author

To clarify, currently the queue pauses if the token is invalid, but we need to automatically log the user out and display a customized version of the Login UI indicating that they have been logged out and should login again (or continue in offline mode).

@sssoleileraaa sssoleileraaa changed the title Pause queue if token is invalid/expired Logout and display login dialog if token is invalid/expired Oct 31, 2019
@sssoleileraaa
Copy link
Contributor Author

Also, here is a useful and relevant comment made by @emkll:

The client does not automatically logout when it has not been in communication with the server for more than the token duration (8h). The assumption that the Client with continuously refresh with the server.

Steps to reproduce:

  1. log into the client
  2. Disable network to client (sd-whonix or the whole computer, or put it to sleep)
  3. wait 8h00m01s for the token to expire
  4. Observe 403's in the client logs, but the client always is logged in locally

This should not happen in normal situations, only if there's an network outage (no communication to the server for 8h)).

In the current format (where the client does not encrypt submission for at-rest-storage) there isn't a very significant impact. However this will pose an issue if #552 is implemented

@redshiftzero
Copy link
Contributor

resolved in #750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants