Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health checker - auto resume #491

Closed
sssoleileraaa opened this issue Jul 24, 2019 · 7 comments
Closed

health checker - auto resume #491

sssoleileraaa opened this issue Jul 24, 2019 · 7 comments

Comments

@sssoleileraaa
Copy link
Contributor

Acceptance Criteria

Given that some operations have repeatedly failed due to network issues
When I do nothing
Then the client should periodically test connectivity
And the error message should disappear when connectivity is restored
And the queue should be resumed when connectivity is restored

@sssoleileraaa
Copy link
Contributor Author

When the queue is paused, the message "The SecureDrop server cannot be reached." with retry link appears in the error status bar. This error message currently doesn't go away until the user clicks "retry." Once the health checker is added with auto-resume, this message should be able to automatically go away without the user action.

@redshiftzero
Copy link
Contributor

For the health checker we could add a new class (similar to the metadata sync running on a timer) that does not have an API token (in the interest of keeping authenticated API calls all being triggered through a single location that is the queue). We could add an SDK endpoint to hit the unauthenticated endpoint here - alternatively, a better thing to do would be to implement freedomofpress/securedrop#4698 as an unauthenticated endpoint since we need it anyway for the client, and then add an SDK method for that.

We're never really going to be able to distinguish 1. general network connectivity issue from 2. admin has just cycled the HidServAuth credentials, so to that end if things keep failing there should probably just be a “Talk to your securedrop administrator” message.

@eloquence
Copy link
Member

Upon consideration, this seems like a nice-to-have feature for the beta, but not a must-have. Hopefully, once all actions are handled by the queue, errors should be rare since we do retries automatically a limited number of times. If the main reason to do this is to have the Retry dialog disappear magically when connectivity is restored, I would vote to defer to Post-Beta. Thoughts @creviera @redshiftzero ?

@redshiftzero
Copy link
Contributor

I agree with this

@eloquence eloquence added this to the Post-Beta milestone Dec 4, 2019
@eloquence
Copy link
Member

(Added to Post-Beta for now.)

@eloquence eloquence modified the milestones: Post-Beta, 0.2.0beta Dec 9, 2019
@eloquence
Copy link
Member

(Adjusted milestones again as this is being handled within #612)

@redshiftzero
Copy link
Contributor

closed by #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants