Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add first and last name to svs.sqlite #450

Closed
sssoleileraaa opened this issue Jun 27, 2019 · 3 comments · Fixed by #453
Closed

add first and last name to svs.sqlite #450

sssoleileraaa opened this issue Jun 27, 2019 · 3 comments · Fixed by #453

Comments

@sssoleileraaa
Copy link
Contributor

Description

We need a place to store first and last name in the client before we can display them in #411

Add first_name and last_name fields to the users table.

@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Jun 27, 2019

also create a hybrid attribute on the users model for journalist initials

Update: a python property will be fine here since we don't need to filter on initials. also create a full name property.

@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Jun 27, 2019

When adding the initials attribute to the user model, follow these rules discussed in freedomofpress/securedrop#4251:

  • First name and last name, use first character of each word: Nina Vizz -> nv
  • First name only, use first two characters: Nina -> ni
  • Last name only, use first two characters: Vizz -> vi
  • No names in the name fields, use first two characters of username: ninavizz -> ni

@sssoleileraaa
Copy link
Contributor Author

No names in the name fields, use first two characters of username: ninavizz -> ni

Need to confirm this last rule with @ninavizz, @eloquence, and @ninavizz tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant