Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global session factory [refactor] #392

Open
sssoleileraaa opened this issue May 30, 2019 · 1 comment
Open

Use global session factory [refactor] #392

sssoleileraaa opened this issue May 30, 2019 · 1 comment
Labels
database SQLite, SQLAlchemy, and data model ♻️ Refactoring This PR is a strict refactoring.

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented May 30, 2019

Description

Instead of passing around sessions and sessionmakers between storage functions, the controller, and our gui, use a global session factory, as describe in Sqlalchemy docs covering Sessions: https://docs.sqlalchemy.org/en/13/orm/session_basics.html

This makes it easy to share a session across separate sections of code if we have to.

@eloquence eloquence changed the title use global session factory [refactor] Use global session factory [refactor] May 30, 2019
@sssoleileraaa sssoleileraaa added the enhancement New feature or request label Jun 1, 2019
@sssoleileraaa
Copy link
Contributor Author

@rocodes - in addition to #1108, also this on your radar

@cfm cfm added database SQLite, SQLAlchemy, and data model ♻️ Refactoring This PR is a strict refactoring. and removed enhancement New feature or request labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database SQLite, SQLAlchemy, and data model ♻️ Refactoring This PR is a strict refactoring.
Projects
None yet
Development

No branches or pull requests

2 participants