Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer pass session_maker to widgets #382

Closed
sssoleileraaa opened this issue May 22, 2019 · 3 comments
Closed

No longer pass session_maker to widgets #382

sssoleileraaa opened this issue May 22, 2019 · 3 comments

Comments

@sssoleileraaa
Copy link
Contributor

Follow-up for #374, which introduces passing around sqlalchemy's scoped_session to GUI widgets in order to access up-to-date database objects.

See if we can instead use the Controller to remove this sqlalchemy dependecy in the GUI.
@sssoleileraaa sssoleileraaa mentioned this issue May 22, 2019
Merged
@heartsucker
Copy link
Contributor

Are you suggesting passing a full reference to the Controller to each widget?

@sssoleileraaa
Copy link
Contributor Author

I think we need to stop passing around session unless we really need to. See my latest commit to resolve this issue: e21084e

sssoleileraaa referenced this issue May 24, 2019
move sqlalchemy session management out of gui
e21084e
@redshiftzero redshiftzero mentioned this issue May 28, 2019
Closed
@sssoleileraaa
Copy link
Contributor Author

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heartsucker @sssoleileraaa