Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spinner for replies in process of being sent #359

Closed
eloquence opened this issue May 7, 2019 · 6 comments
Closed

Add spinner for replies in process of being sent #359

eloquence opened this issue May 7, 2019 · 6 comments
Labels
help wanted Extra attention is needed ux

Comments

@eloquence
Copy link
Member

eloquence commented May 7, 2019

As indicated in this design (publicly viewable static link), when a reply is in the process of being sent, and until a signal is received that it was successfully sent, we want to show a blue spinner vertically aligned with the comment, to show that is in the process of being sent.

This progress indicator disappears as soon as the reply has been sent.

This is another indicator to the user that this reply has not been sent, along with the greyed out state (#350).

@sssoleileraaa
Copy link
Contributor

The screen in this spec is not available anymore. @ninavizz do you know which screen this should point to now?

@ninavizz
Copy link
Member

ninavizz commented Jul 9, 2019

Blue spinny Erik references above, is in these screens... « (and that link is for the section, not a specific screen, so shd always remain live)

@ninavizz
Copy link
Member

ninavizz commented Jul 9, 2019

...but since u asked, blue spinny screen. :)

@redshiftzero
Copy link
Contributor

hey @ninavizz can you drop a public link to the spinner screen and a link to the asset? this one is a good hackathon issue i think

@redshiftzero redshiftzero added the help wanted Extra attention is needed label Nov 7, 2019
@eloquence
Copy link
Member Author

Updated design links in top-level issue. Note that we may want to kick off the spinner the moment a reply is added to the queue, per freedomofpress/securedrop-ux#84 (comment)

@eloquence
Copy link
Member Author

From 2022-08-22 review with @nathandyer @cfm @gonzalo-bulnes @eloquence:

  • Closing for now, we'll revisit in context of broader UX reviews whether a spinner or other progress indicator makes sense here (in addition to the already existing logic for changing the styling of the reply itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed ux
Projects
None yet
Development

No branches or pull requests

4 participants