Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh should be in "active" state while messages are being downloaded #309

Closed
eloquence opened this issue Apr 16, 2019 · 4 comments
Closed

Comments

@eloquence
Copy link
Member

Currently the refresh icon stops being in active state (image) as soon as the metadata for sources has been updated.

Regardless of whether we keep around placeholders for un-downloaded messages or not, this has the potential to be confusing:

  • If we keep the placeholders around in some form, the user may infer that they need to click Refresh again to fetch those messages;
  • If we get rid of the placeholders, they may be confused that messages still appear after a refresh operation is "complete", which may cause them to not trust the "Refresh" function.

The state of the refresh icon should instead be dependent on the completion of all server actions directly associated with it, i.e. not just metadata but also message downloads.

This work is blocked on the completion of the queue (#224). Note also that the network activity indicator (#291) would provide an additional mechanism to tell the user that the client is busy, but they serve slightly different purposes and should be able to co-exist happily.

User Story

As a journalist, I want to know when the client is fetching stuff for me, so that I'm not confused as to whether I need to do something to make it go.

@eloquence
Copy link
Member Author

I'm intentionally not adding this to the beta milestone yet, but we may want to prioritize it based on additional validation with users or our own internal testing.

@ninavizz
Copy link
Member

ninavizz commented Jul 8, 2019

Spreadsheet to indicate how refresh icon and messaging should function w/in that widget: https://docs.google.com/spreadsheets/d/1jXalueqcT8RWWG7osGLFO8dsG6_EB9NdbfJfE_NEmqw/edit?usp=sharing

@sssoleileraaa
Copy link
Contributor

should we close this since it's a bit outdated with the refresh icon removal (#687) and we have this issue: #468

@eloquence
Copy link
Member Author

Yes, good flag - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants