We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The SDK can make it difficult to debug if we change the types of errors that we get back from the server, see #1165 (review), for example, where BAD_REQUEST for a seen request is returned to the client as a ReplyError: https://github.com/freedomofpress/securedrop-sdk/blob/cc5eea0dd4db75f4524ab3d99a31f8efb5a90139/sdclientapi/__init__.py#L205-L206. The client does a lot of response error handling, such as retrying a request based on request type and error, so we should make sure there are not other places in the SDK code that change error types.
seen
ReplyError
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
The SDK can make it difficult to debug if we change the types of errors that we get back from the server, see #1165 (review), for example, where BAD_REQUEST for a
seenrequest is returned to the client as aReplyError: https://github.com/freedomofpress/securedrop-sdk/blob/cc5eea0dd4db75f4524ab3d99a31f8efb5a90139/sdclientapi/__init__.py#L205-L206. The client does a lot of response error handling, such as retrying a request based on request type and error, so we should make sure there are not other places in the SDK code that change error types.The text was updated successfully, but these errors were encountered: