Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[securedrop-export] Log and/or return error message from exception #1738

Closed
sssoleileraaa opened this issue Sep 10, 2019 · 3 comments · Fixed by #1777
Closed

[securedrop-export] Log and/or return error message from exception #1738

sssoleileraaa opened this issue Sep 10, 2019 · 3 comments · Fixed by #1777

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Sep 10, 2019

Description

We just return ERROR_GENERIC here and nothing else, no logs. It would help admins, qa, and developers debug this issue to log.

https://github.com/freedomofpress/securedrop-export/blob/master/securedrop_export/entrypoint.py#L21-L25

@sssoleileraaa
Copy link
Contributor Author

(for now just update code running on sd-export-usb in /opt/venvs/securedrop-export/lib/python3.7/site-packages/securedrop_export)

@gonzalo-bulnes
Copy link
Contributor

@rocodes I think this is a good point, and it's relevant to the work you're doing in freedomofpress/securedrop-export#105 🙂

@gonzalo-bulnes
Copy link
Contributor

Note: if we were to log the original error message, let's make sure we only log it to the debug level, so that regular log files don't contain distrusted strings.

@zenmonkeykstop zenmonkeykstop changed the title Log and/or return error message from exception [securedrop-export] Log and/or return error message from exception Dec 13, 2023
@zenmonkeykstop zenmonkeykstop transferred this issue from freedomofpress/securedrop-export Dec 13, 2023
@rocodes rocodes mentioned this issue Jan 23, 2024
34 tasks
@cfm cfm closed this as completed in #1777 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants