Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Git pre-commit hook for make check-strings #1673

Closed
cfm opened this issue Nov 22, 2023 · 0 comments · Fixed by #1896
Closed

remove Git pre-commit hook for make check-strings #1673

cfm opened this issue Nov 22, 2023 · 0 comments · Fixed by #1896
Assignees
Labels
⚙️ Tooling Improving maintainability and increasing maintainer joy : ) i18n

Comments

@cfm
Copy link
Member

cfm commented Nov 22, 2023

Description

In freedomofpress/securedrop#6232, we wound up deciding against using a pre-commit hook to enforce make check-strings, entrusting this instead to CI.

For consistency, let's remove this hook here too.

How will this impact SecureDrop users?

No user-facing implications.

How would this affect the SecureDrop Workstation threat model?

No threat-model implications.

User Stories

As a SecureDrop contributor, I want the development experiences between the SecureDrop Server and Client to be as similar as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Tooling Improving maintainability and increasing maintainer joy : ) i18n
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant