Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text does not always look fitted in reply widgets #1213

Open
sssoleileraaa opened this issue Feb 3, 2021 · 0 comments
Open

Text does not always look fitted in reply widgets #1213

sssoleileraaa opened this issue Feb 3, 2021 · 0 comments
Labels

Comments

@sssoleileraaa
Copy link
Contributor

Description

The client uses a QScrollArea for displaying a conversation between a source and journalist(s). The scroll area can be resized along with the client window, and #1206 makes each QLabel containing message/ reply text inside the scroll area resizable.

We would like to rely on the GUI framework to handle basic layout scaling, but our workaround to #815 has made this a challenge. Our workaround was to set a fixed width to our QLabel container widgets, so #1206 introduces logic that updates these fixed widths whenever the scroll area resizes. In general this works, but when the QLabel widget contains larger and larger amounts of text (we will display up to 100K characters for each message), you will start to see lag and extra space around the QLabel text as the container is resized.

This looks fine:
looks-fine

This also looks fine:
looks-fine-also

This doesn't look fine (there's some extra white space above the text of the fourth speech bubble):
does-not-look-fine

At this point, I'm interested in revisiting QPlainTextEdit instead of QLabel (see #815 to learn about our previous attempt at doing this) because now we are not relying on the framework so we may no longer encounter the original issue described in that ticket.

Refs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants