Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User to reply widgets #1133

Closed
sssoleileraaa opened this issue Aug 3, 2020 · 1 comment
Closed

Add User to reply widgets #1133

sssoleileraaa opened this issue Aug 3, 2020 · 1 comment
Assignees

Comments

@sssoleileraaa
Copy link
Contributor

Description

To support journalist badges, we need to add logic in the sync to add a user object (the sender) to the ReplyWidget when it's created. We also need to add the currently logged in user object to the ReplyBox so that when we can add it to the ReplyWidget created when the user clicks the send button (and the reply is in a pending state). It would also be useful to have a boolean in the ReplyWidget that indicates whether or not the reply was sent by the currently logged in user so that we can use the same color for that reply badge across the conversation and across all conversations when we implement the GUI.

This change should support offline mode where the currently logged in user can be none.
This change should be tested across all the different reply states: pending, failed, success.
This change should be tested with journalist name changes and deleted journalist accounts.

@sssoleileraaa
Copy link
Contributor Author

Closing in favor of #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant