Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a more specific error message when download failed due to missing GPG key #1075

Open
eloquence opened this issue Apr 28, 2020 · 1 comment

Comments

@eloquence
Copy link
Member

eloquence commented Apr 28, 2020

#1059 improved the error handling for message/reply downloads when a required GPG key is missing, but file download errors still simply get reported as "The file download failed. Please try again" in that case, which is misleading -- trying again will have no effect, and the download itself was not the problem. We also don't support adding multiple keys yet, so there is not always a remediation path.

The language for this case proposed by @ninavizz in #140 (comment) can be seen in the screenshot below (the error bar at the top): "Cannot decrypt file. The Submission Key used for the file is missing."

mockup for 140

@eloquence eloquence added enhancement New feature or request ux labels Apr 28, 2020
@zenmonkeykstop
Copy link
Contributor

This should go in the backlog:

  • the longer folks are using the workstation, the more chance they rotate submission keys, so it's likely to come up
  • that said, the UI above doesn't surface which file is b0rked, so we'd need to think about UX improvements in that vein first
  • a decryption-related exception is thrown, so UI is probably the more challenging part here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Cycle Backlog
Development

No branches or pull requests

2 participants