Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs contain empty strings where path names expected #1060

Closed
eloquence opened this issue Apr 17, 2020 · 1 comment · Fixed by #1069
Closed

Logs contain empty strings where path names expected #1060

eloquence opened this issue Apr 17, 2020 · 1 comment · Fixed by #1069
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

In my prod client I see logs like Decrypted file [file with full path] to folder '' and File decrypted: [basename] (decrypted file in: ).
@eloquence eloquence added the bug Something isn't working label Apr 17, 2020
@eloquence
Copy link
Member Author

From a quick look I suspect this change is pointing os.path.dirname at a variable that doesn't contain the path (original_filename).

@eloquence eloquence mentioned this issue Apr 24, 2020
Merged
4 tasks
@redshiftzero redshiftzero mentioned this issue May 7, 2020
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log intended folders instead of empty strings freedomofpress/securedrop-client
1 participant
@eloquence