Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40-second timeout being used? #1026

Closed
sssoleileraaa opened this issue Mar 30, 2020 · 1 comment
Closed

40-second timeout being used? #1026

sssoleileraaa opened this issue Mar 30, 2020 · 1 comment

Comments

@sssoleileraaa
Copy link
Contributor

Description

Is our 40-seconds timeout being set and used properly?

See discussion: #1007 (comment)

We are passing a timeout value of 40 seconds from the client to the SDK, which passes that value in the request JSON to securedrop-proxy

We are actually not passing that timeout to securedrop-proxy to the current implementation. We are just using it to timeout the qrexec process command we are running in the sd-app vm, https://github.com/freedomofpress/securedrop-sdk/blob/master/sdclientapi/__init__.py#L64
@sssoleileraaa
Copy link
Contributor Author

this is a duplicate of freedomofpress/securedrop-proxy#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sssoleileraaa