From 17f698e326a71f4c89a1bea51073db78686fbdd2 Mon Sep 17 00:00:00 2001 From: Cory Francis Myers Date: Thu, 7 Mar 2024 15:50:35 -0800 Subject: [PATCH] chore: remove pre-commit hooks We'll just let CI enforce "make check-strings" --- client/.githooks/pre-commit | 4 ---- client/Makefile | 6 ------ client/README.md | 4 ---- 3 files changed, 14 deletions(-) delete mode 100755 client/.githooks/pre-commit diff --git a/client/.githooks/pre-commit b/client/.githooks/pre-commit deleted file mode 100755 index 5af313767..000000000 --- a/client/.githooks/pre-commit +++ /dev/null @@ -1,4 +0,0 @@ -#!/bin/sh -TOP=$(git rev-parse --show-toplevel) - -make -C "$TOP" check-strings diff --git a/client/Makefile b/client/Makefile index 346277f12..e783addfc 100644 --- a/client/Makefile +++ b/client/Makefile @@ -7,12 +7,6 @@ all: help PYTHON := $(if $(shell bash -c "command -v python3.9"), python3.9, python3) VERSION_CODENAME ?= bullseye -HOOKS_DIR=.githooks - -.PHONY: hooks -hooks: ## Configure Git to use the hooks provided by this repository. - git config core.hooksPath "$(HOOKS_DIR)" - SEMGREP_FLAGS := --exclude "tests/" --error --strict --verbose .PHONY: semgrep diff --git a/client/README.md b/client/README.md index 0e3730190..6f5d83b11 100644 --- a/client/README.md +++ b/client/README.md @@ -78,7 +78,6 @@ poetry install ``` * You will need Python 3.9 to run the client. If it's not the default `python3` on your installation, you can set `poetry env use python3.9`. - * You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI. 4. Run SecureDrop Client @@ -114,8 +113,6 @@ cd securedrop-client poetry install ``` - * You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI. - 4. Run SecureDrop Client ``` @@ -169,7 +166,6 @@ socat TCP4-LISTEN:8081,fork,reuseaddr TCP4:A.B.C.D:8081 cd securedrop-client poetry install ``` - * You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI. 5. Run SecureDrop Client ```