From 9fabb6cc2fef3e0c1471bf2f426caf9924a6c36f Mon Sep 17 00:00:00 2001 From: Gonzalo Bulnes Guilpain Date: Thu, 22 Sep 2022 10:52:42 +1000 Subject: [PATCH] Add pull request templates for comon tasks This is primarily aimed at preventing us from missing any dependency review in the future. --- .../PULL_REQUEST_TEMPLATE/changelog_update.md | 9 ++++++++ .github/PULL_REQUEST_TEMPLATE/default.md | 17 ++++++++++++++ .../PULL_REQUEST_TEMPLATE/package_addition.md | 22 +++++++++++++++++++ PULL_REQUEST_TEMPLATE.md | 5 ----- 4 files changed, 48 insertions(+), 5 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE/changelog_update.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/default.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/package_addition.md delete mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE/changelog_update.md b/.github/PULL_REQUEST_TEMPLATE/changelog_update.md new file mode 100644 index 00000000..6865a322 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/changelog_update.md @@ -0,0 +1,9 @@ +--- +name: Change log update +about: Prepare the release of a Debian package. + +--- + +## Description + +_Which package are you releasing? Please link to to **release tracking issue**._ diff --git a/.github/PULL_REQUEST_TEMPLATE/default.md b/.github/PULL_REQUEST_TEMPLATE/default.md new file mode 100644 index 00000000..d5fc1a70 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/default.md @@ -0,0 +1,17 @@ +--- +name: Default +about: For all the cases that don't have a specific template. + +--- + +## Description + +_What is the PR doing, and why?_ + +## Test plan + +- Automated tests ([Circle CI][ci]): + - [ ] All Bullseye jobs are passing + - Bookworm failures are not ignored: + - [ ] This PR does not introduce any new Bookworm failures + - [ ] An issue is open for all new Bookworm failures diff --git a/.github/PULL_REQUEST_TEMPLATE/package_addition.md b/.github/PULL_REQUEST_TEMPLATE/package_addition.md new file mode 100644 index 00000000..aed23c7d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/package_addition.md @@ -0,0 +1,22 @@ +--- +name: Package addition +about: Add a dependency for one of our Debian packages. + +--- + +## Description + +_Which packages are you adding, and why?_ + +## Test plan + +- Automated tests ([Circle CI][ci]): + - [ ] All Bullseye jobs are passing + - [ ] Bookworm failures are not ignored: + - This PR does not introduce any new Bookworm failures + - An issue is open for all new Bookworm failures +- Security: + - [ ] A [diff review][review-docs] was performed for all build dependencies + + [ci]: https://app.circleci.com/pipelines/github/freedomofpress/securedrop-debian-packaging + [review-docs]: https://github.com/freedomofpress/securedrop/wiki/Dependency-specification-and-update-policies diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index fcbfda15..00000000 --- a/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,5 +0,0 @@ -## Checklist - -* [ ] `bullseye` builds and jobs are passing -* [ ] This PR does not introduce any new `bookworm` test failures -* [ ] If there are `bookworm` test failures, an issue has been filed for them