Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Build a tribute page, user story # 8 fails #883

Closed
ghost opened this issue May 1, 2019 · 2 comments
Closed

Build a tribute page, user story # 8 fails #883

ghost opened this issue May 1, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented May 1, 2019

Issue Description

I am facing issue in user story # 8, depsite the fact that i have included profile-link and target attribute into a tag

Browser Information

  • Browser Name, Version: Version 73.0.3683.103
  • Operating System: Windows 10
  • Mobile, Desktop, or Tablet: Desktop

Your Code / Link to Your Pen

https://codepen.io/anon/pen/vMwqyK


#### Screenshot
<!-- Add a screenshot of your issue -->


@abhishekakade
Copy link
Contributor

abhishekakade commented May 1, 2019

@Khan-saab, isn't this supposed to be a personal portfolio project (and not a tribute page)?

So I ran the tests (Personal Portfolio tests) on your project and saw that there are multiple elements using the same id="profile-link". ids should always be unique and so you cannot use them more than once. You should use css classes (class="profiles") instead if you want to use it on more than one element. That fixed the #8 test/user story.

Then adding a media query to your project, setting the height of #welcome-section equal to the height of viewport and changing your #navbar styles so it always remains at the top cleared all the remaining tests.

I'd also like to suggest you to use codepen's built in 'Analyze HTML' and 'Analyze CSS' features. You will find them in the drop down menu at top right corner of each HTML, CSS and JS editor panes on codepen. These tools help a lot with debugging. They will show you all the errors in your HTML/CSS/JS so you can fix them easily.

@abhishekakade
Copy link
Contributor

I think this issue can be closed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@abhishekakade and others