Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

profile link #636

Closed
rudylemus opened this issue Oct 11, 2018 · 4 comments
Closed

profile link #636

rudylemus opened this issue Oct 11, 2018 · 4 comments
Labels
other: decayed Stale issues that need follow up from commentators. Should be closed in 7 days of no activity.

Comments

@rudylemus
Copy link

Issue Description

Browser Information

  • Browser Name, Version:
  • Operating System:
  • Mobile, Desktop, or Tablet:

Your Code / Link to Your Pen

 
 
 

Screenshot

@floydkim
Copy link

Hello.
I think it's about "Build a Personal Portfolio Webpage" challenge.

I couldn't pass the test #8 "My portfolio should have a link with an id of "profile-link", which opens my GitHub or FCC profile in a new tab." although there was no wrong code :
<a id="profile-link" href="">link</a>

I solved this by replacing "(double quotation) to ' (single).
<a id='profile-link' href="">link</a>

Please correct this bug.

(I'm using Chrome 70.0.3538.102 (64bit) on macOS Sierra.)

@ValeraS
Copy link
Contributor

ValeraS commented Nov 18, 2018

@floydkim The test does not depend on quotation marks. Provided code does not contain target="_blank", which causes an error. If you still consider the error in quotes, please give a link to your pen with the error reproduction.

@floydkim
Copy link

floydkim commented Nov 18, 2018

@ValeraS target="_blank" is omitted because I thought this attribute is not important about this problem. :)

And I found quotation mark is not a solution.
I'm still working on this portfolio challenge (contents and details) so some tags are added after I wrote a comment.
Now, after changing single quotation mark to double, tests are passed.
I'm confused.

https://codepen.io/for12/pen/yQbzgd
now it has no error so I don't recommend you to visit this pen.

@ValeraS ValeraS added the other: decayed Stale issues that need follow up from commentators. Should be closed in 7 days of no activity. label Dec 24, 2018
@ValeraS ValeraS closed this as completed Dec 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
other: decayed Stale issues that need follow up from commentators. Should be closed in 7 days of no activity.
Projects
None yet
Development

No branches or pull requests

4 participants
@ValeraS @floydkim @rudylemus and others