Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text conveying wrong information.Lock an Element to the Browser Window with Fixed Positioning #18043

Closed
dsandeepchary opened this issue Aug 23, 2018 · 5 comments

Comments

@dsandeepchary
Copy link

dsandeepchary commented Aug 23, 2018

Lesson in the curriculum has a wrong typo which conveys wrong information, i.e, Written 'absolute' where it should be 'fixed' in the second paragraph.

@TomerPacific
Copy link
Contributor

@dsandeepchary ,
I actually don't think this is a typo.
The first paragraph explains the use and meaning of the position attribute of fixed,
The second paragraph elaborates more on this issue by stating that as opposed to absolute positioning, the fixed positioning locks the element in it's place.

@joshalling
Copy link
Member

@TomerPacific I think you are correct, however the wording is a little bit ambiguous. It might be good to clarify it like this:

One key difference from the between the fixed and absolute positions is that the an element with a fixed position won't move when the user scrolls.

@TomerPacific
Copy link
Contributor

@joshalling,
you mind if I go ahead and fix this issue?

@joshalling
Copy link
Member

@TomerPacific Go right ahead! 👍 👍

I'll keep an eye out for your pull request.

@TomerPacific
Copy link
Contributor

@joshalling ,
I have created a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants