Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): Correct a regex in ES6 read-only challenge #41

Merged
merged 1 commit into from
Jun 24, 2018
Merged

fix(challenges): Correct a regex in ES6 read-only challenge #41

merged 1 commit into from
Jun 24, 2018

Conversation

thomaslombart
Copy link
Contributor

The regex testing if the user has entered console.log(SENTENCE); has
been modified. In fact, the regex was broken before.

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17679 in freeCodeCamp's main repository

The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit d951bf9 into freeCodeCamp:dev Jun 24, 2018
@scissorsneedfoodtoo
Copy link
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this issue, @thomlom. Also, thank you for closing your first PR in the main repo and submitting another here. We're all really looking forward to your next contribution!

Bouncey pushed a commit that referenced this pull request Jun 24, 2018
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
raisedadead pushed a commit that referenced this pull request Jun 24, 2018
# [2.0.0](v1.2.1...v2.0.0) (2018-06-24)

### Bug Fixes

* **challenges:** Correct a regex in ES6 read-only challenge ([#41](#41)) ([cf9336a](cf9336a))
* **challenges:** fix responsive web design cert claim ([6e02f9d](6e02f9d))
* **interview-prep:** Remove duplicates ([816be51](816be51))

### Features

* **interview-prep:** Porting Rosetta problems ([#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([21930a8](21930a8))

### BREAKING CHANGES

* **challenges:** none
@thearunster
Copy link

@scissorsneedfoodtoo I see that this fix has been merged into staging and master. But I still see this issue in https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/es6/declare-a-read-only-variable-with-the-const-keyword/. It still shows the old code (without the fix).

Is there one more step before the fix is in production?

@scissorsneedfoodtoo
Copy link
Contributor

@thearunster, thank you for investigating.

I believe it's because the NPM package of all the recently updated challenges, including this fix, is now version 2.0.0. However, package.json for Learn has the following:

"@freecodecamp/curriculum": "^1.2.1"

So I think this will have to be manually bumped, as the caret only matches the most recent patch and/or minor version--the last and middle digits--but ignores major releases like the one we just had.

We'll make the change to the above file ASAP!

@thearunster
Copy link

@scissorsneedfoodtoo , glad to be of help!
BTW, I only noticed this because there were 2 issues on the freecodecamp repo talking about this problem:
#17716 and #17679

The second one has a lot of people reporting this issue.

@johnkennedy9147
Copy link
Contributor

johnkennedy9147 commented Jun 26, 2018

@Bouncey did this yesterday in freeCodeCamp/freeCodeCamp#17707 but I guess it hasn't been pushed to production yet.

Edited so link to PR works

@huyenltnguyen
Copy link
Member

@johnkennedy9147 That was an update on the freeCodeCamp repo, but another update needs to be done on the learn repo, I think.

anku255 pushed a commit to anku255/curriculum that referenced this pull request Jun 30, 2018
# [2.0.0](freeCodeCamp/curriculum@v1.2.1...v2.0.0) (2018-06-24)

### Bug Fixes

* **challenges:** Correct a regex in ES6 read-only challenge ([freeCodeCamp#41](freeCodeCamp#41)) ([cf9336a](freeCodeCamp@cf9336a))
* **challenges:** fix responsive web design cert claim ([6e02f9d](freeCodeCamp@6e02f9d))
* **interview-prep:** Remove duplicates ([816be51](freeCodeCamp@816be51))

### Features

* **interview-prep:** Porting Rosetta problems ([#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([21930a8](freeCodeCamp@21930a8))

### BREAKING CHANGES

* **challenges:** none
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants