-
-
Notifications
You must be signed in to change notification settings - Fork 125
fix(challenges): Correct a regex in ES6 read-only challenge #41
Conversation
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨ Thank you for submitting a PR for this issue, @thomlom. Also, thank you for closing your first PR in the main repo and submitting another here. We're all really looking forward to your next contribution! |
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
# [2.0.0](v1.2.1...v2.0.0) (2018-06-24) ### Bug Fixes * **challenges:** Correct a regex in ES6 read-only challenge ([#41](#41)) ([cf9336a](cf9336a)) * **challenges:** fix responsive web design cert claim ([6e02f9d](6e02f9d)) * **interview-prep:** Remove duplicates ([816be51](816be51)) ### Features * **interview-prep:** Porting Rosetta problems ([#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([21930a8](21930a8)) ### BREAKING CHANGES * **challenges:** none
@scissorsneedfoodtoo I see that this fix has been merged into staging and master. But I still see this issue in https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/es6/declare-a-read-only-variable-with-the-const-keyword/. It still shows the old code (without the fix). Is there one more step before the fix is in production? |
@thearunster, thank you for investigating. I believe it's because the NPM package of all the recently updated challenges, including this fix, is now version 2.0.0. However,
So I think this will have to be manually bumped, as the caret only matches the most recent patch and/or minor version--the last and middle digits--but ignores major releases like the one we just had. We'll make the change to the above file ASAP! |
@scissorsneedfoodtoo , glad to be of help! The second one has a lot of people reporting this issue. |
@Bouncey did this yesterday in freeCodeCamp/freeCodeCamp#17707 but I guess it hasn't been pushed to production yet. Edited so link to PR works |
@johnkennedy9147 That was an update on the freeCodeCamp repo, but another update needs to be done on the learn repo, I think. |
# [2.0.0](freeCodeCamp/curriculum@v1.2.1...v2.0.0) (2018-06-24) ### Bug Fixes * **challenges:** Correct a regex in ES6 read-only challenge ([freeCodeCamp#41](freeCodeCamp#41)) ([cf9336a](freeCodeCamp@cf9336a)) * **challenges:** fix responsive web design cert claim ([6e02f9d](freeCodeCamp@6e02f9d)) * **interview-prep:** Remove duplicates ([816be51](freeCodeCamp@816be51)) ### Features * **interview-prep:** Porting Rosetta problems ([#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([21930a8](freeCodeCamp@21930a8)) ### BREAKING CHANGES * **challenges:** none
The regex testing if the user has entered console.log(SENTENCE); has
been modified. In fact, the regex was broken before.
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #17679 in freeCodeCamp's main repository