Skip to content

Commit

Permalink
Finish the exclusion of drafts from clap.h
Browse files Browse the repository at this point in the history
  • Loading branch information
abique committed Jan 8, 2024
1 parent 06d6c85 commit e11e63b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ that is, a plugin binary compiled with CLAP 1.x can be loaded by any other
CLAP 1.y.

To work with CLAP, include [clap/clap.h](include/clap/clap.h).
To also include the draft extensions, include [clap/all.h](include/clap/all.h).

The two most important objects are `clap_host` and `clap_plugin`.

Expand Down
2 changes: 2 additions & 0 deletions conventions/extension-id.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ Where:
## Draft

An extension is considered a draft extension if it is in the [draft](../include/clap/ext/draft/) folder.
Make sure to also include it in [all.h](../include/clap/all.h).

When the extension is migrating from draft to stable, its extension ID must not change.
Move its inclusion from [all.h](../include/clap/all.h) into [clap.h](../include/clap/clap.h).

All extensions must go though the draft phase first.

Expand Down
6 changes: 4 additions & 2 deletions include/clap/draft.h → include/clap/all.h
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
#pragma once

#include "clap.h"

#include "factory/draft/plugin-invalidation.h"
#include "factory/draft/plugin-state-converter.h"

#include "ext/draft/ambisonic.h"
#include "ext/draft/cv.h"
#include "ext/draft/midi-mappings.h"
#include "ext/draft/extensible-audio-ports.h"
#include "ext/draft/resource-directory.h"
#include "ext/draft/transport-control.h"
#include "ext/draft/triggers.h"
#include "ext/draft/tuning.h"
#include "ext/draft/extensible-audio-ports.h"
3 changes: 1 addition & 2 deletions src/main.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include <clap/clap.h>
#include <clap/draft.h>
#include <clap/all.h>

// The purpose of this file is to check that all headers compile
int main(int argc, char **argv) {
Expand Down
3 changes: 1 addition & 2 deletions src/main.cc
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include <clap/clap.h>
#include <clap/draft.h>
#include <clap/all.h>

// The purpose of this file is to check that all headers compile

Expand Down

0 comments on commit e11e63b

Please sign in to comment.