setPrioritizeFlashSound() is not used.

[GoogleCodeExporter]

What version of GWT are you using? 1.3.3? 1.4.61? Other?
1.5.2

What version of the gwt-voices jar file or library file are you using?
1.5.5 and/or svn

What steps will reproduce the problem? Please attach sample code if you 
can.
1. call setPrioritizeFlashSound(false)
2. create a sound and play it

What is the expected output? What do you see instead?
1. Expected to be able to prefer not-flash, but flash is always preferred. 


Do you have a workaround?
no

Please provide any additional information below.

The variable SoundController.prioritizeFlashSound is never used.

Here is a nearly unreadable grep for case insensitive priortizeFlashSound:

gwt-voices-read-only $ grep -ir "prioritizeFlashSound" *
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:  
private boolean prioritizeFlashSound = false;
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:  public 
boolean isPrioritizeFlashSound() {
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:    
return prioritizeFlashSound;
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:   * 
@param prioritizeFlashSound whether or not to prioritize Flash play back
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:  public 
void setPrioritizeFlashSound(boolean prioritizeFlashSound) {
Voices/src/com/allen_sauer/gwt/voices/client/SoundController.java:    
this.prioritizeFlashSound = prioritizeFlashSound;

Original issue reported on code.google.com by [email protected] on 13 Sep 2008 at 3:23

Attachments:

[GoogleCodeExporter]

Mind if I ask: what is your use case for avoiding flash?

Original comment by fredsa on 29 Oct 2008 at 3:29

• Changed state: NeedsInfo

[GoogleCodeExporter]

Flash 9 causes some linux browsers to hang (Firefox, Opera).
Also there seems to maybe be a problem with flash in IE6 on Win2K, but its 
possible 
something else is wrong with my VM that im testing it with.

The function should probably be implemented or removed or depricated. 

Original comment by [email protected] on 29 Oct 2008 at 8:12

[GoogleCodeExporter]

Thanks for reporting this

I removed the never implemented methods in r219

Original comment by fredsa on 30 Jul 2009 at 4:12

• Changed state: Fixed