Popover does not disappear with angular 1.3.x

[tzar]

From the docs, $animate.removeClass now has a different syntax:

removeClass(element, className, [options]); (returns promise)

textAngular passes a done callback which is never called, so the popup is not removed. To correct this, some modification like:

$animate.removeClass(scope.displayElements.popover, 'in').then(function(){

Would be needed, but I am not familiar with the testing framework used, and do not know how to make this also work for angular 1.2 cleanly.

As a sidenote, the animation classes seem to be missing from the copied CSS when running without bootstrap.

Cheers

[SimeonC]

Thanks for letting me know, I'll get onto it when I can - from memory I think all I need to do to make your code snippet 1.2 compatible is this: $q.when($animate.removeClass(scope.displayElements.popover, 'in')).then(function(){

Can you let me know which version of textAngular are you using please?

[tzar]

Thanks for the speedy reply! I'm running 1.3.0-pre12, with the CSS from the src/ directory as it's not placed into dist/

[SimeonC]

OK, will be fixed later today when I push up the next lot of fixes.

I'm not entirely sure what to do with the css, I've left it in the src folder as it isn't minified and I don't want two copies of it floating around.

[tzar]

Thanks 😄