Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder 1.3.0-pre12 #390

Closed
snekbaev opened this issue Nov 4, 2014 · 5 comments
Closed

placeholder 1.3.0-pre12 #390

snekbaev opened this issue Nov 4, 2014 · 5 comments
Labels

Comments

@snekbaev
Copy link

snekbaev commented Nov 4, 2014

Hi,
if I have a placeholder TA crashes with an error (it was ok in 1.2.2) in IE11 (didn't test other browsers):

IndexSizeError <div class="ng-pristine ng-untouched ng-valid ta-bind" id="taTextElement7836777544209690" contenteditable="true" ng-model="html" placeholder="please enter claim text" ta-bind="ta-bind">
DOMException object:

{
   [functions]: ,
   __proto__: { },
   ABORT_ERR: 20,
   code: 1,
   constructor: { },
   DATA_CLONE_ERR: 25,
   DOMSTRING_SIZE_ERR: 2,
   HIERARCHY_REQUEST_ERR: 3,
   INDEX_SIZE_ERR: 1,
   INUSE_ATTRIBUTE_ERR: 10,
   INVALID_ACCESS_ERR: 15,
   INVALID_CHARACTER_ERR: 5,
   INVALID_MODIFICATION_ERR: 13,
   INVALID_NODE_TYPE_ERR: 24,
   INVALID_STATE_ERR: 11,
   message: "IndexSizeError",
   name: "IndexSizeError",
   NAMESPACE_ERR: 14,
   NETWORK_ERR: 19,
   NO_DATA_ALLOWED_ERR: 6,
   NO_MODIFICATION_ALLOWED_ERR: 7,
   NOT_FOUND_ERR: 8,
   NOT_SUPPORTED_ERR: 9,
   PARSE_ERR: 81,
   QUOTA_EXCEEDED_ERR: 22,
   SECURITY_ERR: 18,
   SERIALIZE_ERR: 82,
   SYNTAX_ERR: 12,
   TIMEOUT_ERR: 23,
   TYPE_MISMATCH_ERR: 17,
   URL_MISMATCH_ERR: 21,
   VALIDATION_ERR: 16,
   WRONG_DOCUMENT_ERR: 4
}

also is there a reason why 1.2.2 uses sanitize v1.3.0-build.2711+sha.facd904 and 1.3.0-pre12 uses 1.2.26?

@SimeonC
Copy link
Collaborator

SimeonC commented Nov 4, 2014

Thanks for the bug, does it crash just at startup or do you have to do something to get it to error?

The sanitizer rarely changes, I patch it in when they've done something major so I think those two are nearly the same. I'll update it again before we do a stable release.

@snekbaev
Copy link
Author

snekbaev commented Nov 5, 2014

happens immediately on directive load (I render it inside ng-repeat at the moment)

@SimeonC
Copy link
Collaborator

SimeonC commented Nov 10, 2014

EDIT: My bad, testing on the wrong page. I can replicate it.

@SimeonC
Copy link
Collaborator

SimeonC commented Nov 10, 2014

I think this is due to the user agent string being changed in IE 11, see here http://msdn.microsoft.com/en-us/library/ie/hh869301(v=vs.85).aspx.

I think if you force IE to pretend it's IE 10 you shouldn't get this problem, in the meantime I have to fix those browser detection tests...

@SimeonC
Copy link
Collaborator

SimeonC commented Nov 10, 2014

OK, got the issue - is a problem with IE 11 and stylesheets in JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants