Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordered list and number list broken in Firefox #290

Closed
anitin opened this issue Aug 26, 2014 · 8 comments
Closed

ordered list and number list broken in Firefox #290

anitin opened this issue Aug 26, 2014 · 8 comments
Labels

Comments

@anitin
Copy link

anitin commented Aug 26, 2014

Hi fraywing,

This is a great library and I am trying to use it on my project.

I experimented with 1.2.0 version and every thing worked great.

But when I upgraded to 1.2.2 the ordered list / numbered list is not working (intermittently) on Firefox. I even used the editor on textangular.com and there too the ol and ul does't work (intermittently)

I tried Firefox on Mac -- the issue is present.
Firefox on Windows 7 -- the issue is not present.
Firefox on Windows 8.1 -- the issue is present.
IE 11 on windows 8.1 -- the issue is present.

But when I rollback to 1.2.0 version, everything works !! But I really need the tooltip feature in 1.2.2.
Any help is much appreciated

Thanks
Ankit

@SimeonC
Copy link
Collaborator

SimeonC commented Aug 26, 2014

Hi, yes I am aware we have some bugs with lists in 1.2.2 - there's a few individual issues out there.

Can you give the specifics of what is not working to help me debug this please?

@SimeonC SimeonC added the bug label Aug 28, 2014
@anitin
Copy link
Author

anitin commented Aug 29, 2014

Thanks for response Simeon .

I did some more testing and below are the specifics :

  1. Without writing any text if you click on bulleted list icon then it does not insert any bullet list on the cursor position - FF 29.0 on mac, FF 26, FF 31 on win7 does not work. Works fine in Chrome,IE9 & IE11
  2. If you write something in the text area and then press bulleted list, bulleted list is inserted but the text moves to a new line - FF 29.0 on mac, FF 26, FF 31 on win7 does not work. Works fine in Chrome,IE9 & IE11

I also found that "Paste" does not work in IE11 - I have raised a separate issue #298 for it

I will be happy to test/validate the fixes if you need.

Thanks
Ankit

@anitin
Copy link
Author

anitin commented Sep 15, 2014

@SimeonC Hi Simeon, did you find anything ? I could see that in textangular code, you were using document.execCommand in 1.2.0 but in 1.2.2 your are trying to handle lists by yourself. Was there any issue with using execCommand for lists.
Can i use execCommand for list without modifying textangular code ?

@SimeonC
Copy link
Collaborator

SimeonC commented Sep 15, 2014

Yea there were a bunch of issues with lists and inconsistencies with execCommand across browsers.

I did a patch late last week with some fixes (no version yet) if you grab the version from the main master repo do you still get the issues?

EDIT: Theres now a pre-release available with the fix in, please re-open if this is not fixed in the new version.

@SimeonC SimeonC closed this as completed Sep 16, 2014
@rednaxus
Copy link

hi, sorry to bother, but I don't think this is fixed in the 1.2.2 marked version currently in the src directory... (not sure if this is 1.2.2 or 1.3.0)
Firefox Mac lists don't work much at all, several other problems as well with h1, h2, etc.

I get this:
"Error: $nodes.pop(...) is undefined

@SimeonC
Copy link
Collaborator

SimeonC commented Oct 18, 2014

Thanks for letting me know. Yes there are bugs...
Current src is 1.3.0-prerealease 4, for 1.2.2 see the releases tab, cdn's or install via bower.

@SimeonC
Copy link
Collaborator

SimeonC commented Oct 18, 2014

To update this - it's specific to Firefox, but the tests still pass, yay :(

@SimeonC SimeonC reopened this Oct 18, 2014
@bulucseku
Copy link

Hi,
I have tried your plugin, it was working fine but after updating the angular.js to version 1.3 it is not working.
Would you please let me know what may be the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants