fix(textAngular): Prevent updateSelectedStyles loop when out of docum…

…ent focus Potential fix for #443
textAngular · Dec 16, 2014 · 81a37de · 81a37de
1 parent 0187345
commit 81a37de
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/dist/textAngular.min.js b/dist/textAngular.min.js
diff --git a/lib/main.js b/lib/main.js
@@ -537,7 +537,9 @@ textAngular.directive("textAngular", [
 						_toolbars.updateSelectedStyles(angular.element(_selection));
 					}else _toolbars.updateSelectedStyles();
 					// used to update the active state when a key is held down, ie the left arrow
-					if(scope._bUpdateSelectedStyles) $timeout(scope.updateSelectedStyles, 200);
+					/* istanbul ignore else: browser only check */
+					if(scope._bUpdateSelectedStyles && $document.hasFocus()) $timeout(scope.updateSelectedStyles, 200);
+					else scope._bUpdateSelectedStyles = false;
 				};
 				// start updating on keydown
 				_keydown = function(){

diff --git a/src/textAngular.js b/src/textAngular.js
@@ -1985,7 +1985,9 @@ textAngular.directive("textAngular", [
 						_toolbars.updateSelectedStyles(angular.element(_selection));
 					}else _toolbars.updateSelectedStyles();
 					// used to update the active state when a key is held down, ie the left arrow
-					if(scope._bUpdateSelectedStyles) $timeout(scope.updateSelectedStyles, 200);
+					/* istanbul ignore else: browser only check */
+					if(scope._bUpdateSelectedStyles && $document.hasFocus()) $timeout(scope.updateSelectedStyles, 200);
+					else scope._bUpdateSelectedStyles = false;
 				};
 				// start updating on keydown
 				_keydown = function(){

diff --git a/test/textAngular.spec.js b/test/textAngular.spec.js
@@ -1016,7 +1016,8 @@ describe('textAngular', function(){
 				expect(!iButton.hasClass('active'));
 			});
 
-			it('should change on keydown and stop on keyup', inject(function($timeout){
+			it('should change on keydown and stop on keyup', inject(function($timeout, $document){
+				$document.hasFocus = function(){return true;};
 				editorScope.displayElements.text.triggerHandler('keydown');
 				range.selectNodeContents(editorScope.displayElements.text.find('p').find('u')[0]);
 				sel.setSingleRange(range);