Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing null-check in bind of RemoteService #8

Open
dittodhole opened this issue Nov 29, 2015 · 0 comments
Open

Missing null-check in bind of RemoteService #8

dittodhole opened this issue Nov 29, 2015 · 0 comments

Comments

@dittodhole
Copy link

In line 480 there is the following parsing:

xml2js.parseString(data, {explicitArray: false, ignoreXmlns: true, mergeAttrs: true}, function (err, json) {

This call does not check the argument err

httpRequest(this.SCPDURL, function(err, data) {

Which is in my case true and data is null, which results in an unhandled exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant