Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewing a subscription causes notify to fail #22

Open
rtyle opened this issue Sep 18, 2019 · 1 comment
Open

Renewing a subscription causes notify to fail #22

rtyle opened this issue Sep 18, 2019 · 1 comment

Comments

@rtyle
Copy link

rtyle commented Sep 18, 2019

Running a subscribing & resubscribing (non peer-upnp) UPnP client against your binary-light-device causes it to fail to notify after the first resubscription.

http://upnp.org/specs/arch/UPnP-arch-DeviceArchitecture-v1.1.pdf

4.1.3 Renewing a subscription with SUBSCRIBE with SID
...
CALLBACK
(No CALLBACK header field is used to renew an event subscription.)

Each such resubscription is handled by peer-upnp as a new subscription, generating a new SID with no callbacks (as "no CALLBACK header field is used to renew"). Eventually the service is flooded with subscriptions - none of which would work because there is no callback. Actually, when notifying the first such one, the code throws an exception because it doesn't expect no callbacks.

@rtyle rtyle changed the title Renewing a subscription is handled wrong; causes notify to fail Renewing a subscription is handled wrong and causes notify to fail Sep 18, 2019
@rtyle rtyle changed the title Renewing a subscription is handled wrong and causes notify to fail Renewing a subscription causes notify to fail Sep 18, 2019
@rtyle
Copy link
Author

rtyle commented Sep 18, 2019

pull request #23

@rtyle rtyle closed this as completed Sep 18, 2019
@rtyle rtyle reopened this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant