Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation section 'add-abilities-to-hooks-context': wrong import file reference #92

Open
uplke opened this issue Apr 1, 2023 · 0 comments

Comments

@uplke
Copy link

uplke commented Apr 1, 2023

Steps to reproduce

https://feathers-casl.netlify.app/getting-started.html#add-abilities-to-hooks-context

Expected behavior

References file from the previous paragraph:
import { defineAbilitiesFor } from "./authentication.abilities";

Actual behavior

References file from the previous paragraph by the wrong name:
import { defineAbilitiesFor } from "./abilities";

TBD

Just another little one - sorry these trickle in now...
It might be worth noting that /src/services/authentication/ is not created when using the FeathersJS CLI. As a consequence, the authentication service has no auto-generated hooks and validators/resolvers.
Instead, there is /src/authentication.js, which should probably be the default place for the hooks in your proposed src/services/authentication/authentication.hooks.ts

Viele Grüße

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant