Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to configure max database connections for site database users #2316

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Nov 29, 2024

Fixes #2315 #2317
(Check issue for more details)

  • Clean up non required fields and functions of old implementation
  • Limit database user's max connection. The total allowed connections for each site will be 16 by default. But upon any request, we can configure it from backend
  • Frontend Changes
  • Allow to set label/title for database user to identify easily (Fixes 2317)

@tanmoysrt tanmoysrt linked an issue Nov 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 42.19%. Comparing base (f806bcb) to head (953586a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...s/doctype/site_database_user/site_database_user.py 0.00% 7 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
+ Coverage   39.69%   42.19%   +2.49%     
==========================================
  Files         375      376       +1     
  Lines       28535    28691     +156     
==========================================
+ Hits        11328    12107     +779     
+ Misses      17207    16584     -623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanmoysrt tanmoysrt linked an issue Nov 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: show label for database users and permission manager feat: limit connections per site db user
1 participant