Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): Fix typo in COA setup #44190

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Nov 18, 2024

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 18, 2024
@ruthra-kumar ruthra-kumar self-requested a review November 19, 2024 08:45
@ruthra-kumar ruthra-kumar self-assigned this Nov 19, 2024
@ruthra-kumar
Copy link
Member

regression: #42755

@ruthra-kumar ruthra-kumar merged commit a9bb6b9 into frappe:develop Nov 19, 2024
13 checks passed
@cogk cogk deleted the fix-coa-setup-wizard branch November 19, 2024 12:17
ruthra-kumar added a commit that referenced this pull request Nov 19, 2024
…-44190

fix(setup): Fix typo in COA setup (backport #44190)
@FHenry
Copy link
Contributor

FHenry commented Nov 19, 2024

In my test environement, create_chart_of_accounts_based_on was empty in case of company create from exsting template.
It was a fresh develop install on develop branch where I test it several times, may be somthing change between creation date of the faulty PR (13 th August 2024 ) and now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants