-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate round off account for opening (backport #42588) #44136
Merged
ruthra-kumar
merged 11 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-42588
Nov 14, 2024
Merged
refactor: separate round off account for opening (backport #42588) #44136
ruthra-kumar
merged 11 commits into
version-15-hotfix
from
mergify/bp/version-15-hotfix/pr-42588
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a5b2285)
(cherry picked from commit 88e6816) # Conflicts: # erpnext/accounts/general_ledger.py
(cherry picked from commit fc46ebc)
(cherry picked from commit 96e3c2a)
(cherry picked from commit 5021c7c) # Conflicts: # erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
(cherry picked from commit 7926735)
(cherry picked from commit 193ea9a)
(cherry picked from commit a5d6a25)
(cherry picked from commit b7edc6d) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit cf11ac8)
mergify
bot
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
November 14, 2024 07:01
Cherry-pick of 88e6816 has failed:
Cherry-pick of 5021c7c has failed:
Cherry-pick of b7edc6d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Rounding Entries are unavoidable in high precision Sales / Purchase Invoices that post opening entries. As the default Round off account is of type Profit and Loss, such Invoices is currently not possible to be submitted.
Solution
A separate Round Off account just for opening entries could help address this issue. This account will be under Liability.
Abandoned tasks
Tasks:
patch to update existing companiesadd round off for all templates in verified and unverified directoryAlternate approach
Abandoning above approach of updating templates and creating account automatically.
System will not auto-create any accounts. Instead,
round_off_for_opening
, which is not mandatoryaccount_type
-Round Off for Opening
- is introducedToDo:
Internal Ref: 18968
fixes: #42376
This is an automatic backport of pull request #42588 done by Mergify.