fix: populate payment schedule from payment terms (backport #44082) #44083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit c81eb6c)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
# [15.42.0](v15.41.2...v15.42.0) (2024-11-13) ### Bug Fixes * add default height to POS item card selector (backport [#44071](#44071)) ([#44075](#44075)) ([65ec7c5](65ec7c5)) * add field conversion_factor when include_uom is settled ([#43701](#43701)) ([f387a8f](f387a8f)) * better gls for purchases with tax witholding ([#42743](#42743)) ([705a26a](705a26a)) * bind this object explicitly on callback event function ([3423d3c](3423d3c)) * calculate percentage received and delivered considering over-receipt and over-delivery (backport [#43870](#43870)) ([#44030](#44030)) ([5958d0c](5958d0c)) * Cannot read properties of undefined (reading 'work_order_closed') (backport [#44117](#44117)) ([#44122](#44122)) ([c1983a4](c1983a4)) * consider service item cost in the RM cost of the BOM (backport [#43962](#43962)) ([#44111](#44111)) ([6e83fec](6e83fec)) * Drop Shipping address based on customer shopping address ([8af005c](8af005c)) * duplicate items and outdated item price in POS (backport [#42978](#42978)) ([#44038](#44038)) ([4cde77d](4cde77d)) * exception on register reports when filtered on cost center ([be07421](be07421)) * improved the conditions for determining voucher subtypes ([58ca4a2](58ca4a2)) * incorrect produced qty in Production Plan Summary (backport [#44112](#44112)) ([#44113](#44113)) ([bce7acf](bce7acf)) * item mapping from modal to batch form ([#44090](#44090)) ([9ac54f6](9ac54f6)) * item not set in the batch quick entry form (backport [#44028](#44028)) ([#44031](#44031)) ([6dcd015](6dcd015)) * Negative stock validation against inventory dimension (backport [#43834](#43834)) ([#43846](#43846)) ([b314f38](b314f38)) * NoneType while updating ordered_qty in SO for removed items ([978a007](978a007)) * not able to cancel DN (backport [#44108](#44108)) ([#44109](#44109)) ([290bdde](290bdde)) * not able to reconcile expired batches ([#44012](#44012)) ([4ba07a4](4ba07a4)) * patch ([107d53b](107d53b)) * populate payment schedule from payment terms (backport [#44082](#44082)) ([#44083](#44083)) ([363f151](363f151)) * purchase receipt creation from SCR ([#44095](#44095)) ([e3d7468](e3d7468)) * slow reposting due to SABB update ([3e29ae8](3e29ae8)) * sort by ascending to get the first period closing voucher (backport [#44029](#44029)) ([#44035](#44035)) ([56f25ae](56f25ae)) * task path (backport [#44073](#44073)) ([#44078](#44078)) ([34b5639](34b5639)) * tyeerror while saving pick list ([7d09832](7d09832)) * update payment amount for partial pos return ([61559be](61559be)) * update per_billed value in Purchase Receipt while creating Debit Note ([#43977](#43977)) ([a833dd6](a833dd6)) * when company is created with other company template Chart of Account the Create Taxe Template failed ([#42755](#42755)) ([e6894b9](e6894b9)) ### Features * Add item group filtering for search results ([2754793](2754793)) * add template taxe for charts of account France - Plan Comptable General avec code ([#42757](#42757)) ([865786e](865786e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version: 15 and 14
fixes: #44039
Before:
The code checked if
is_returnwas exactly0with this condition:This would only work if
is_returnwas set to0. Ifis_returnwasn't available or set to something else, the condition wouldn't trigger, and the payment schedule wouldn't populate.After:
The code was changed to:
This condition checks if
is_returnis either not set or has a falsy value (like0,null, orundefined). So, even ifis_returnis missing in some doctypes, the payment schedule will still auto-populate.is_returnfield is not available in certain documents. The new check ensures the payment schedule populates correctly even whenis_returnis not set.This is an automatic backport of pull request fix: populate payment schedule from payment terms #44082 done by Mergify.