Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list view and form status not same for purchase order #43690

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: list view and form status not same for purchase order #43690

merged 1 commit into from
Oct 16, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

The listview status is completed but the form status is To Bill which should be same. The default precision 2 causing the issue. To replicate the issue, follow the below steps

  • Create the PO with the rate as 1,57,327.00
  • Create the PI against the above PO and change the rate as 1,57,323.00
  • Create the PR with rate as 1,57,327.00
  • After that check the status of the above PO, the listview status and form status is not same.
Screenshot 2024-10-16 at 1 27 41 PM

After Fix

Screenshot 2024-10-16 at 1 38 22 PM

@rohitwaghchaure rohitwaghchaure merged commit a671fe1 into frappe:develop Oct 16, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@rohitwaghchaure @mergify
fix: list view and form status not same for purchase order (#43690)
3c427fa 
(cherry picked from commit a671fe1)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
#	erpnext/buying/doctype/purchase_order/purchase_order_list.js
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
@rohitwaghchaure @mergify
fix: list view and form status not same for purchase order (#43690)
2b3e1a1 
(cherry picked from commit a671fe1)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
#	erpnext/buying/doctype/purchase_order/purchase_order_list.js
This was referenced Oct 16, 2024
Closed
Merged
rohitwaghchaure added a commit that referenced this pull request Oct 16, 2024
@mergify @rohitwaghchaure
fix: list view and form status not same for purchase order (backport #…
a33d553 
…43690) (#43692)

* fix: list view and form status not same for purchase order (#43690)

(cherry picked from commit a671fe1)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
#	erpnext/buying/doctype/purchase_order/purchase_order_list.js

* chore: fix conflicts

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <[email protected]>
mergify bot added a commit that referenced this pull request Oct 16, 2024
@mergify
fix: list view and form status not same for purchase order (backport #…
4987fd0 
…43690) (#43692)

* fix: list view and form status not same for purchase order (#43690)

(cherry picked from commit a671fe1)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
#	erpnext/buying/doctype/purchase_order/purchase_order_list.js

* chore: fix conflicts

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <[email protected]>
(cherry picked from commit a33d553)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
@mergify mergify bot mentioned this pull request Oct 16, 2024
Closed
mergify bot added a commit that referenced this pull request Oct 17, 2024
@mergify
fix: list view and form status not same for purchase order (backport #…
752d175 
…43690) (#43692)

* fix: list view and form status not same for purchase order (#43690)

(cherry picked from commit a671fe1)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.js
#	erpnext/buying/doctype/purchase_order/purchase_order_list.js

* chore: fix conflicts

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <[email protected]>
(cherry picked from commit a33d553)
@mergify mergify bot mentioned this pull request Oct 17, 2024
Merged
rohitwaghchaure added a commit that referenced this pull request Oct 17, 2024
@rohitwaghchaure
Merge pull request #43706 from frappe/mergify/bp/version-15/pr-43692
6f98fe1 
fix: list view and form status not same for purchase order (backport #43690) (backport #43692)
frappe-pr-bot pushed a commit that referenced this pull request Oct 17, 2024
@frappe-bot
chore(release): Bumped to Version 15.38.4
08cabd1 
## [15.38.4](v15.38.3...v15.38.4) (2024-10-17)

### Bug Fixes

* list view and form status not same for purchase order (backport [#43690](#43690)) ([#43692](#43692)) ([752d175](752d175))
frappe-pr-bot pushed a commit that referenced this pull request Oct 23, 2024
@frappe-bot
chore(release): Bumped to Version 15.39.0
e0a45a5 
# [15.39.0](v15.38.4...v15.39.0) (2024-10-23)

### Bug Fixes

* "show_remarks" checkbox in Process statement of accounts ([f7717c9](f7717c9))
* added validation for UOM must be whole number (backport [#43710](#43710)) ([#43712](#43712)) ([60ffcd0](60ffcd0))
* Call super onload_post_render inside pos_invoice.js ([1281d9d](1281d9d))
* coupon code validation logic ([aeaadb1](aeaadb1))
* **deferred_revenue:** Escape account in query ([fac27d9](fac27d9))
* do not make new depreciation for fully depreciated asset ([ddb38db](ddb38db))
* Freeze Screen on load invoices on POS Closing Entry ([f343d5a](f343d5a))
* get party advance amount based on account ([b673377](b673377))
* get period estimate till service end date ([148d7e7](148d7e7))
* get stock accounts from the doc instead of db in validate_stock_accounts ([39387e9](39387e9))
* incorrect amount in bank clearance ([52be45c](52be45c))
* lead create opp from connection not working ([9e56f21](9e56f21))
* list view and form status not same for purchase order (backport [#43690](#43690)) ([#43692](#43692)) ([a33d553](a33d553))
* only show pay button for specific doctype in portal ([d2e5b2a](d2e5b2a))
* party_balance based on company in payment entry ([04fbcc6](04fbcc6))
* remove extra space ([50dd8d9](50dd8d9))
* removed unmerged patches ([2e0cf36](2e0cf36))
* Required Changes to Support e-Waybill Generation for Material Transfer Return ([#43061](#43061)) ([2205ae8](2205ae8))
* show total amount on report summary ([ab20344](ab20344))
* use correct variable in error message (backport [#43790](#43790)) ([#43792](#43792)) ([879b2b7](879b2b7))
* Workspace link for Work Order Consumed Materials report (backport [#43753](#43753)) ([#43754](#43754)) ([1fa9030](1fa9030))

### Features

* added assignee email field in asset maintenance log ([a3b8f97](a3b8f97))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure