fix: sales person allocated amount calculation error nonetype and float #35293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-tests
Gubbu77
changed the title
deepeshgarg007
pushed a commit
that referenced
this pull request
May 15, 2023
…at (#35293) fix: sales person allocated amount calculation error nonetype and float (#35293) fix: sales person allocated amount calculation error nontype and float (cherry picked from commit 0c8276e) Co-authored-by: Indrajith.vs <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 16, 2023
## [14.24.2](v14.24.1...v14.24.2) (2023-05-16) ### Bug Fixes * add missing options for `Content Align` ([3697e8f](3697e8f)) * allow over-payment against SO ([#35079](#35079)) ([fe9e0c2](fe9e0c2)) * bad strings format for command get-untraslated ([#34361](#34361)) ([5a54296](5a54296)) * bad strings format for update-translations ([#34592](#34592)) ([e3c1d73](e3c1d73)) * bom item filter issue ([098603d](098603d)) * cancelled vouchers in tax withheld vouchers list ([#35309](#35309)) ([c41e1d7](c41e1d7)) * enqueue submit/cancel action for stock entry to avoid time out error ([457846e](457846e)) * force to do reposting for cancelled document ([6f96e5d](6f96e5d)) * function `batch_no` should only be declared once ([#35115](#35115)) ([26928b3](26928b3)) * incorrect packing items ([ab56470](ab56470)) * inventory dimension for inter company transfer return use case ([6d121b8](6d121b8)) * inventory dimension for material transfer not working ([1d8050d](1d8050d)) * item list view not working ([d9efa66](d9efa66)) * port option for additional_conditions in item wise sales register ([#35187](#35187)) ([42037f9](42037f9)) * recalculate costs in SCR while reposting ([9a8ee62](9a8ee62)) * sales person allocated amount calculation error nonetype and float ([#35293](#35293)) ([3a7c69f](3a7c69f)) * test case ([3f8928b](3f8928b)) * test case ([9b2b467](9b2b467)) * typo ([2772a91](2772a91)) * unable to create partial invoice with auto fetch terms enabled ([#35285](#35285)) ([fa9fa97](fa9fa97)) * update workstation hour rate when workstation change in job card ([bc88415](bc88415)) * **UX:** misc "home" onboarding improvements (backport [#35319](#35319)) ([#35321](#35321)) ([f8c58b6](f8c58b6)) * validate for active sla ([#32132](#32132)) ([38e27a6](38e27a6)) ### Performance Improvements * cache and simplify queries for holiday list (backport [#35315](#35315)) ([#35318](#35318)) ([0e78403](0e78403))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported operant error
File "apps/erpnext/erpnext/controllers/accounts_controller.py", line 158, in validate
self.calculate_taxes_and_totals()
File "apps/erpnext/erpnext/controllers/accounts_controller.py", line 356, in calculate_taxes_and_totals
self.calculate_contribution()
File "apps/erpnext/erpnext/controllers/selling_controller.py", line 171, in calculate_contribution
self.amount_eligible_for_commission * sales_person.allocated_percentage / 100.0,
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'
@marination