fix(ux): don't throw error when company defaults aren't set #34825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prompt account input.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34825 +/- ##
===========================================
+ Coverage 63.83% 63.87% +0.03%
===========================================
Files 810 810
Lines 59711 59718 +7
===========================================
+ Hits 38119 38144 +25
+ Misses 21592 21574 -18
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
* fix(ux): don't throw error when company defaults aren't set; instead prompt account input. * fix: translate label and title (cherry picked from commit 51c4338)
deepeshgarg007
pushed a commit
that referenced
this pull request
Apr 14, 2023
fix(ux): don't throw error when company defaults aren't set (#34825) * fix(ux): don't throw error when company defaults aren't set; instead prompt account input. * fix: translate label and title (cherry picked from commit 51c4338) Co-authored-by: Devin Slauenwhite <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-04-19) ### Bug Fixes * Add offers info to website item ([#34873](#34873)) ([f1a1fc6](f1a1fc6)) * Advance payment against payment terms ([#34872](#34872)) ([7461239](7461239)) * change discuss forum url ([#34891](#34891)) ([8f26d62](8f26d62)) * don't show disabled warehouses in the Warehouse Wise Stock Balance report ([461780d](461780d)) * Don't use stale item details ([#34847](#34847)) ([c11aeba](c11aeba)) * for Tree Type item and item group show net amount ([#31776](#31776)) ([7c8194a](7c8194a)) * linters issues ([c53dc06](c53dc06)) * Remove unnecessary checkbox from Accounts doctype ([#34821](#34821)) ([0cf6144](0cf6144)) * selling workspace is not migrating properly ([79fd38c](79fd38c)) * stock reco test case ([2f356dc](2f356dc)) * too many writes error while making backdated stock reconciliation ([a981b79](a981b79)) * unable to change `company` for manual `Serial No` entry ([2e7043c](2e7043c)) * **ux:** don't throw error when company defaults aren't set ([#34825](#34825)) ([15f5e8d](15f5e8d)) * whitelist doc method ([09b92fd](09b92fd)) ### Features * add german sales tax template ([#34823](#34823)) ([3738ea5](3738ea5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously when "Set Exchange Gain/Loss", or "Set Write Off" button appeared, if their respective company default wasn't set an error would prompt.
Now a prompt is displayed for the user to provide an account to write off too.
Before PR
After PR
Backport
version-14
version-13