Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad strings format for update-translations #34592

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

akiratfli
Copy link
Contributor

@akiratfli akiratfli commented Mar 26, 2023

In translation not work in some of doctypes issue.

I have check that accounts/utils.py, pick_list.py already be fixed on the develop branch, but bank_transaction.py not yet.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #34592 (8ecbc2c) into develop (f7780cd) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34592   +/-   ##
========================================
  Coverage    63.80%   63.80%           
========================================
  Files          810      810           
  Lines        59524    59524           
========================================
  Hits         37977    37977           
  Misses       21547    21547           
Impacted Files Coverage Δ
...ounts/doctype/bank_transaction/bank_transaction.py 67.46% <50.00%> (ø)

@deepeshgarg007 deepeshgarg007 merged commit 07c9b99 into frappe:develop Mar 28, 2023
@akiratfli akiratfli deleted the dev-bad-strings branch May 12, 2023 02:12
@akiratfli akiratfli restored the dev-bad-strings branch May 12, 2023 02:13
@akiratfli akiratfli deleted the dev-bad-strings branch May 12, 2023 02:13
akiratfli pushed a commit to akiratfli/erpnext that referenced this pull request May 12, 2023
frappe-pr-bot pushed a commit that referenced this pull request May 16, 2023
## [14.24.2](v14.24.1...v14.24.2) (2023-05-16)

### Bug Fixes

* add missing options for `Content Align` ([3697e8f](3697e8f))
* allow over-payment against SO ([#35079](#35079)) ([fe9e0c2](fe9e0c2))
* bad strings format for command get-untraslated  ([#34361](#34361)) ([5a54296](5a54296))
* bad strings format for update-translations ([#34592](#34592)) ([e3c1d73](e3c1d73))
* bom item filter issue ([098603d](098603d))
* cancelled vouchers in tax withheld vouchers list ([#35309](#35309)) ([c41e1d7](c41e1d7))
* enqueue submit/cancel action for stock entry to avoid time out error ([457846e](457846e))
* force to do reposting for cancelled document ([6f96e5d](6f96e5d))
* function `batch_no` should only be declared once ([#35115](#35115)) ([26928b3](26928b3))
* incorrect packing items ([ab56470](ab56470))
* inventory dimension for inter company transfer return use case ([6d121b8](6d121b8))
* inventory dimension for material transfer not working ([1d8050d](1d8050d))
* item list view not working ([d9efa66](d9efa66))
* port option for additional_conditions in item wise sales register ([#35187](#35187)) ([42037f9](42037f9))
* recalculate costs in SCR while reposting ([9a8ee62](9a8ee62))
* sales person allocated amount calculation error nonetype and float ([#35293](#35293)) ([3a7c69f](3a7c69f))
* test case ([3f8928b](3f8928b))
* test case ([9b2b467](9b2b467))
* typo ([2772a91](2772a91))
* unable to create partial invoice with auto fetch terms enabled ([#35285](#35285)) ([fa9fa97](fa9fa97))
* update workstation hour rate when workstation change in job card ([bc88415](bc88415))
* **UX:** misc "home" onboarding improvements (backport [#35319](#35319)) ([#35321](#35321)) ([f8c58b6](f8c58b6))
* validate for active sla ([#32132](#32132)) ([38e27a6](38e27a6))

### Performance Improvements

* cache and simplify queries for holiday list (backport [#35315](#35315)) ([#35318](#35318)) ([0e78403](0e78403))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants