Skip to content

Commit

Permalink
Merge pull request #44008 from frappe/version-15-hotfix
Browse files Browse the repository at this point in the history
  • Loading branch information
sagarvora authored Nov 7, 2024
2 parents 9ccdb98 + 47a8fc2 commit 7d8d9cf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion erpnext/accounts/deferred_revenue.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def build_conditions(process_type, account, company):
)

if account:
conditions += f"AND {deferred_account}='{frappe.db.escape(account)}'"
conditions += f"AND {deferred_account}={frappe.db.escape(account)}"
elif company:
conditions += f"AND p.company = {frappe.db.escape(company)}"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ def get_dimension_filter_map():
a.applicable_on_account, d.dimension_value, p.accounting_dimension,
p.allow_or_restrict, a.is_mandatory
FROM
`tabApplicable On Account` a, `tabAllowed Dimension` d,
`tabApplicable On Account` a,
`tabAccounting Dimension Filter` p
LEFT JOIN `tabAllowed Dimension` d ON d.parent = p.name
WHERE
p.name = a.parent
AND p.disabled = 0
AND p.name = d.parent
""",
as_dict=1,
)
Expand All @@ -97,7 +97,6 @@ def get_dimension_filter_map():
f.allow_or_restrict,
f.is_mandatory,
)

frappe.flags.dimension_filter_map = dimension_filter_map

return frappe.flags.dimension_filter_map
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,9 @@ def split_invoices(invoices):
if not item.serial_no and not item.serial_and_batch_bundle:
continue

return_against_is_added = any(d for d in _invoices if d.pos_invoice == pos_invoice.return_against)
return_against_is_added = any(
d for d in _invoices if d and d[0].pos_invoice == pos_invoice.return_against
)
if return_against_is_added:
break

Expand Down
2 changes: 1 addition & 1 deletion erpnext/templates/pages/projects.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def get_tasks(project, start=0, search=None, item_status=None):
"parent_task",
],
limit_start=start,
limit_page_length=10,
limit_page_length=100,
)
task_nest = []
for task in tasks:
Expand Down

0 comments on commit 7d8d9cf

Please sign in to comment.