Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc unicommerce fixes #178

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix: misc unicommerce fixes #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad180fc
fix: capture curency code from order data
ankush Mar 31, 2022
aa9e1fd
fix: better error message in case of HTTPError
ankush Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ecommerce_integrations/unicommerce/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def request(
response = requests.request(
url=url, method=method, headers=headers, json=body, params=params, files=files
)
# unicommerce gives useful info in response text, show it in error logs
response.reason = cstr(response.reason) + cstr(response.text)
response.raise_for_status()
except Exception:
create_unicommerce_log(status="Error", make_new=True)
Expand Down
1 change: 1 addition & 0 deletions ecommerce_integrations/unicommerce/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ def _create_order(order: UnicommerceOrder, customer) -> None:
"tax_category": get_dummy_tax_category(),
"company_address": company_address,
"dispatch_address_name": dispatch_address,
"currency": order.get("currencyCode"),
}
)

Expand Down