Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(easy-install): allow installation on linux mint versions 19 and 20 #1141

Closed
wants to merge 1 commit into from

Conversation

gunic0rn
Copy link

What type of a PR is this?

  • Changes to Existing Features
  • New Feature Submissions
  • Bug Fix
  • Breaking Change (include change in API behaviours, etc.)

Closes frappe/easy_install#16

Please provide enough information so that others can review your pull request:

This fix adds Linux Mint 19 and 20 to the list of supported dists, to allow the installation script to proceed on Linux Mint versions.


Explain the details for making this change. What existing problem does the pull request solve? The following checklist could help

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally prior to submission?
  • Have you successfully run tests with your changes locally?
  • Does your commit message have an explanation for your changes and why you'd like us to include them?
  • Docs have been added / updated
  • Tests for the changes have been added (for bug fixes / features)
  • Did you modify the existing test cases? If yes, why?

Linux Mint users need to be able to install and setup bench on their machines.

Screenshots/GIFs

bench_linux_mint_acceptable

@gavindsouza
Copy link
Collaborator

@gunic0rn Can you confirm the install works with Linux mint 19 and 20?

@gavindsouza
Copy link
Collaborator

@gunic0rn Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for installation of bench on linux mint
2 participants