Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stiff-to-unified strips leading/trailing punctuation from #17

Open
frankier opened this issue Mar 10, 2019 · 1 comment
Open

stiff-to-unified strips leading/trailing punctuation from #17

frankier opened this issue Mar 10, 2019 · 1 comment

Comments

@frankier
Copy link
Owner

Probably needs some thought.

  • Should the text be retokenised to include this punctuation in a separate token?
    • If so, should it be marked there was no space in the text? Probably not since this isn't the case for the previous tokenisation step.
    • Should this retokenisation take place in an ad-hoc way (only for instances) or should a FinnPOS retokenisation be done instead.
  • How does this interact with instances which are part of a compound word?
  • What about when/if segmentation is applied? Segmentation is marked as happening, but does this mean it should be marked for punctuation too? Probably not.

STIFF/scripts/munge.py

Line 111 in 2a5d03a

# XXX: This approach just deletes the leading punctation.

STIFF/scripts/munge.py

Line 144 in 2a5d03a

# XXX: This approach just deletes the trailing punctation.

May need to take consideration of #16
@frankier
Copy link
Owner Author

Also related: #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frankier