Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded colors and commented colors? #9

Open
frere-jacques opened this issue Jan 20, 2023 · 2 comments
Open

Hard coded colors and commented colors? #9

frere-jacques opened this issue Jan 20, 2023 · 2 comments

Comments

@frere-jacques
Copy link

I saw that there are some hard coded colors within the theme by running:
cat src/*.xml | grep value=\"[a-zA-Z0-9] and cat src/includes/*.xml | grep value=\"[a-zA-Z0-9]

Further I find out by running cat src/includes/*.xml | grep \# that there is a # infront of many colors in python file.

Since I am unsure whether this is intended or not I didn't provide a fix for it.

@francma
Copy link
Owner

francma commented Jan 29, 2023

It's not intended. All hardcoded colors should be replaced with $envs in the future.

@frere-jacques
Copy link
Author

Good to know. I will see if I can fix some of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants