Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows #5

Closed
franciscolourenco opened this issue Nov 7, 2016 · 9 comments
Closed

Add support for windows #5

franciscolourenco opened this issue Nov 7, 2016 · 9 comments

Comments

@franciscolourenco
Copy link
Owner

No description provided.

@franciscolourenco
Copy link
Owner Author

@jbucaran any idea what people on windows are using to display notifications?

@jorgebucaran
Copy link
Contributor

jorgebucaran commented Feb 2, 2017

@franciscolourenco
Copy link
Owner Author

@jbucaran do you have any stats on the percentage of users on Windows?
Trying to evaluate if it would be worthwhile to work on this since I never use windows.

@jorgebucaran
Copy link
Contributor

Definitely low. I think you can keep the issue open, but not make it a priority?

@zhangnew
Copy link

For wsl : microsoft/WSL#2466

PS C:\WINDOWS\system32> Install-Module -Name BurntToast

set -U __done_notification_command 'powershell.exe -command New-BurntToastNotification -Text WSL-ok'

@franciscolourenco
Copy link
Owner Author

@zhangnew do you have a proposal on how to integrate this in the package?

@6A61736F6E206E61646572
Copy link

6A61736F6E206E61646572 commented Nov 13, 2019

If being run under WSL:

  • can detect if being run under WSL using grep Microsoft /proc/version
  • can detect if BurntToast is installed using powershell.exe -command Get-Module -Name BurntToast. (Need to figure out how to get the exit status from this command...)

However the biggest issue is detecting whether or not the terminal window is in the foreground.

@ammgws
Copy link
Contributor

ammgws commented Nov 23, 2019

AFAIK when running on Windows, fish would just be running in something like cygwin or WSL where you cannot get the focused state of the app. However since this script also seems to work with tmux, perhaps on Windows notifications could still be sent when using tmux.

I don't seem to be getting any notifications from detached tmux windows on my linux machine, so first I will debug that and once it is working I will check using Windows and if successful can submit a PR for (limited) Windows support.

@ammgws
Copy link
Contributor

ammgws commented Dec 5, 2019

Solved with #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants