Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report]: miss makezero in slice init #2019

Open
alingse opened this issue May 27, 2024 · 1 comment
Open

[Bug report]: miss makezero in slice init #2019

alingse opened this issue May 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alingse
Copy link

alingse commented May 27, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9243212476/job/25427061144

====================================================================================================
append to slice `arr` with non-zero initialized length at https://github.com/frain-dev/convoy/blob/main/worker/task/queue_stuck_event_deliveries.go#L25:11
====================================================================================================

the arr := make([]string, len(evs)) should be arr := make([]string, 0, len(evs))

@alingse alingse added the bug Something isn't working label May 27, 2024
Copy link

linear bot commented May 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant