-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save spatial scales without float imprecisions #76
Comments
One way to force fractal to write "0.1625" is that we keep track of pixel sizes as strings (first in the metadata parsing, and then downstream), and then include the strings in the More in general, I'm not sure this goal is really important: |
I agree that this should not affect any of our downstream processing and if it does, we should fix that. Not sure we can guarantee the same for e.g. visualization tools, but I'd mostly hope they wouldn't be affected. In the end, while the error is tiny, we still should do our best not to introduce any changes to the metadata. If we're limited in the precision of reading out the metadata for processing, so be it (=> let's make sure our processing is stable to that level). But would be great if the metadata is actually saved as it was originally parsed. I agree though, this isn't a high priority issue, I assigned it to backlog for the time being. |
Currently, the .zattrs files contain spatial scales as in:
The correct x & y scales would be 0.1625 though. Our processing can handle this minimal float rounding, but it would be better to save the actual correct numbers in the metadata. This is a (minimal) distortion of the metadata and could have weird side-effects (e.g. what if it's rounded slightly differently for 2 OME-Zarr files that are opened in the same viewer? will all downstream processing always be stable to pixel sizes that are slightly off?)
The text was updated successfully, but these errors were encountered: