Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is writing into the MAIN AndroidOS directory instead of /Android/data/com.fr3ts0n.ecu.gui.androbd/ #273

Open
ieffuie4 opened this issue Jul 18, 2024 · 3 comments

Comments

@ieffuie4
Copy link

Describe the bug

Now i understand why AndrOBD ask for such a deep file access permissions and cant work without it. Its writing in the MAIN Android directory. This is really nothing a app should do. This should really be fixed. Doing so is for sure just wrong.
After i did this #271 (comment) i gave the AndrOBD really deep file access permissions. Now AndrOBD could in theory delete my whole phone, read all my pictures, access the files of every other app, and so on.
AndrOBD wants for no reason to create a directory here:
/com.fr3ts0n.ecu.gui.androbd
Not where it should be: /Android/data/com.fr3ts0n.ecu.gui.androbd/

You do not have to ask the user/AndroidOS for granting additional file access permissions when you want to write into the app-own directory: /Android/data/com.fr3ts0n.ecu.gui.androbd/
Please take a look into this Android 5.0+ app sourcecode that do NOT ask the user for any additional file access permissions: https://github.com/libre-tube/LibreTube

To Reproduce

#271 (comment)

Expected behavior

Do not ask for any file access permissions and just use the default directory /Android/data/

Important details on your environment:

  • Android OS version: 14
  • AndrOBD version: 2.7.0
  • OBD adapter type: not related
  • Connected vehicle make, type, year, engine size: not related
@serppower
Copy link

Is this fixed?

@fr3ts0n
Copy link
Owner

fr3ts0n commented Oct 16, 2024

No, issue is still open

@ieffuie4
Copy link
Author

There was no new test build or any code change since the report. Yes, its still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants